Re: [PATCH V6 2/5] PCI/TPH: Add Steering Tag support
From: kernel test robot
Date: Sat Sep 28 2024 - 18:21:25 EST
Hi Wei,
kernel test robot noticed the following build errors:
[auto build test ERROR on pci/next]
[also build test ERROR on pci/for-linus linus/master next-20240927]
[cannot apply to v6.11]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Wei-Huang/PCI-Add-TLP-Processing-Hints-TPH-support/20240928-055915
base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
patch link: https://lore.kernel.org/r/20240927215653.1552411-3-wei.huang2%40amd.com
patch subject: [PATCH V6 2/5] PCI/TPH: Add Steering Tag support
config: sparc64-randconfig-r062-20240929 (https://download.01.org/0day-ci/archive/20240929/202409290628.jR98LDA9-lkp@xxxxxxxxx/config)
compiler: sparc64-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240929/202409290628.jR98LDA9-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409290628.jR98LDA9-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
drivers/pci/tph.c: In function 'write_tag_to_msix':
>> drivers/pci/tph.c:230:26: error: 'struct pci_dev' has no member named 'msix_base'; did you mean 'msix_cap'?
230 | vec_ctrl = pdev->msix_base + msix_idx * PCI_MSIX_ENTRY_SIZE;
| ^~~~~~~~~
| msix_cap
vim +230 drivers/pci/tph.c
205
206 /* Write ST to MSI-X vector control reg - Return 0 if OK, otherwise -errno */
207 static int write_tag_to_msix(struct pci_dev *pdev, int msix_idx, u16 tag)
208 {
209 struct msi_desc *msi_desc = NULL;
210 void __iomem *vec_ctrl;
211 u32 val, mask, st_val;
212 int err = 0;
213
214 msi_lock_descs(&pdev->dev);
215
216 /* Find the msi_desc entry with matching msix_idx */
217 msi_for_each_desc(msi_desc, &pdev->dev, MSI_DESC_ASSOCIATED) {
218 if (msi_desc->msi_index == msix_idx)
219 break;
220 }
221
222 if (!msi_desc) {
223 err = -ENXIO;
224 goto err_out;
225 }
226
227 st_val = (u32)tag;
228
229 /* Get the vector control register (offset 0xc) pointed by msix_idx */
> 230 vec_ctrl = pdev->msix_base + msix_idx * PCI_MSIX_ENTRY_SIZE;
231 vec_ctrl += PCI_MSIX_ENTRY_VECTOR_CTRL;
232
233 val = readl(vec_ctrl);
234 mask = PCI_MSIX_ENTRY_CTRL_ST_LOWER | PCI_MSIX_ENTRY_CTRL_ST_UPPER;
235 val &= ~mask;
236 val |= FIELD_PREP(mask, st_val);
237 writel(val, vec_ctrl);
238
239 /* Read back to flush the update */
240 val = readl(vec_ctrl);
241
242 err_out:
243 msi_unlock_descs(&pdev->dev);
244 return err;
245 }
246
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki