[PATCH] arcnet: com20020-pci: Add check devm_kasprintf() returned value
From: Charles Han
Date: Sat Sep 28 2024 - 22:37:51 EST
devm_kasprintf() can return a NULL pointer on failure but this
returned value in com20020pci_probe() is not checked.
Fixes: 8890624a4e8c ("arcnet: com20020-pci: add led trigger support")
Signed-off-by: Charles Han <hanchunchao@xxxxxxxxxx>
---
drivers/net/arcnet/com20020-pci.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/arcnet/com20020-pci.c b/drivers/net/arcnet/com20020-pci.c
index c5e571ec94c9..6639ee11a7f8 100644
--- a/drivers/net/arcnet/com20020-pci.c
+++ b/drivers/net/arcnet/com20020-pci.c
@@ -254,6 +254,8 @@ static int com20020pci_probe(struct pci_dev *pdev,
card->tx_led.name = devm_kasprintf(&pdev->dev, GFP_KERNEL,
"pci:green:tx:%d-%d",
dev->dev_id, i);
+ if (!card->tx_led.default_trigger || !card->tx_led.name)
+ return -ENOMEM;
card->tx_led.dev = &dev->dev;
card->recon_led.brightness_set = led_recon_set;
@@ -263,6 +265,9 @@ static int com20020pci_probe(struct pci_dev *pdev,
card->recon_led.name = devm_kasprintf(&pdev->dev, GFP_KERNEL,
"pci:red:recon:%d-%d",
dev->dev_id, i);
+ if (!card->recon_led.default_trigger || !card->recon_led.name)
+ return -ENOMEM;
+
card->recon_led.dev = &dev->dev;
ret = devm_led_classdev_register(&pdev->dev, &card->tx_led);
--
2.31.1