Re: [PATCH] iio: dac: ad5770r: Convert to get_unaligned_le16
From: Jonathan Cameron
Date: Sun Sep 29 2024 - 12:51:20 EST
On Sat, 28 Sep 2024 21:48:05 +0530
Abhash Jha <abhashkumarjha123@xxxxxxxxx> wrote:
> Convert the manual shifting to use `get_unaligned_le16` api.
>
> Signed-off-by: Abhash Jha <abhashkumarjha123@xxxxxxxxx>
Looks straight forward so I've applied this, but plenty of time for
additional reviews if anyone has time to take a look.
Thanks,
Jonathan
> ---
> drivers/iio/dac/ad5770r.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/ad5770r.c b/drivers/iio/dac/ad5770r.c
> index c360ebf52..12c98f3e6 100644
> --- a/drivers/iio/dac/ad5770r.c
> +++ b/drivers/iio/dac/ad5770r.c
> @@ -17,6 +17,7 @@
> #include <linux/regmap.h>
> #include <linux/regulator/consumer.h>
> #include <linux/spi/spi.h>
> +#include <asm/unaligned.h>
>
> #define ADI_SPI_IF_CONFIG_A 0x00
> #define ADI_SPI_IF_CONFIG_B 0x01
> @@ -325,7 +326,7 @@ static int ad5770r_read_raw(struct iio_dev *indio_dev,
> if (ret)
> return 0;
>
> - buf16 = st->transf_buf[0] + (st->transf_buf[1] << 8);
> + buf16 = get_unaligned_le16(st->transf_buf);
> *val = buf16 >> 2;
> return IIO_VAL_INT;
> case IIO_CHAN_INFO_SCALE: