Re: [PATCH] MAINTAINERS: Add security/Kconfig.hardening to hardening section
From: Nathan Chancellor
Date: Sun Sep 29 2024 - 17:00:48 EST
On Sun, Sep 29, 2024 at 10:20:59PM +0200, Paul Moore wrote:
> On September 28, 2024 8:26:28 PM Nathan Chancellor <nathan@xxxxxxxxxx> wrote:
> > When running get_maintainer.pl on security/Kconfig.hardening, only the
> > security subsystem folks show up, even though they have never taken
> > patches to this file:
> >
> > $ scripts/get_maintainer.pl security/Kconfig.hardening
> > Paul Moore <...> (supporter:SECURITY SUBSYSTEM)
> > James Morris <...> (supporter:SECURITY SUBSYSTEM)
> > "Serge E. Hallyn" <...> (supporter:SECURITY SUBSYSTEM)
> > linux-security-module@xxxxxxxxxxxxxxx (open list:SECURITY SUBSYSTEM)
> > linux-kernel@xxxxxxxxxxxxxxx (open list)
> >
> > $ git log --format=%cn --no-merges security/Kconfig.hardening | sort | uniq -c
> > 3 Andrew Morton
> > 1 Greg Kroah-Hartman
> > 18 Kees Cook
> > 2 Linus Torvald
> >
> > Add it to the hardening section so that the KSPP folks are also shown,
> > which matches reality over who should comment on and take said patches
> > if necessary.
> >
> > Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> > ---
> > MAINTAINERS | 1 +
> > 1 file changed, 1 insertion(+)
>
> For the sake of casual observers, the reason James, Serge, or I haven't
> merged anything in Kconfig.hardening isn't due to any malicious intent or
> lack of appreciation, rather it is out of respect for KSPP and not wanting
> to step on Kees' toes.
Right, I did not mean for this to come off in an accusatory way, so my
apologies if it did. I merely wanted to codify this arrangement so that
patches get picked up or acked by the correct people in the future since
I had to send one earlier and I noticed it did not match reality (with
the data to prove it heh). I hope it is fairly obvious that Kees has a
good working relationship with you and the other security subsystem
folks if one pays attention to the mailing list :) and for the record,
even with this change, get_maintainer.pl still shows the security/
maintainers and list for this file, so you can still be kept in the loop
if so desired.
> I've happily merged KSPP related patches to those subsystems which I'm
> tasked with looking after and I plan to continue to do so.
Always happy to have as many KSPP allies as possible :)
Cheers,
Nathan