Re: [PATCH] rust: kunit: use C-string literals to clean warning

From: Trevor Gross
Date: Sun Sep 29 2024 - 19:44:19 EST


On Fri, Sep 27, 2024 at 12:44 PM Miguel Ojeda <ojeda@xxxxxxxxxx> wrote:
>
> Starting with upstream Rust commit a5e3a3f9b6bd ("move
> `manual_c_str_literals` to complexity"), to be released in Rust 1.83.0
> [1], Clippy now warns on `manual_c_str_literals` by default, e.g.:
>
> error: manually constructing a nul-terminated string
> --> rust/kernel/kunit.rs:21:13
> |
> 21 | b"\x013%pA\0".as_ptr() as _,
> | ^^^^^^^^^^^^^ help: use a `c""` literal: `c"\x013%pA"`
> |
> = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals
> = note: `-D clippy::manual-c-str-literals` implied by `-D warnings`
> = help: to override `-D warnings` add `#[allow(clippy::manual_c_str_literals)]`
>
> Apply the suggestion to clean up the warnings.
>
> Link: https://github.com/rust-lang/rust-clippy/pull/13263 [1]
> Signed-off-by: Miguel Ojeda <ojeda@xxxxxxxxxx>

Reviewed-by: Trevor Gross <tmgross@xxxxxxxxx>