RE: [PATCH v1 2/5] ARM: dts: aspeed: yosemite4: remove led gpio pca9552 on fan boards

[Delphine_CC_Chiu/WYHQ/Wiwynn]

> -----Original Message-----
> From: Andrew Jeffery <andrew@xxxxxxxxxxxxxxxxxxxx>
> Sent: Friday, September 27, 2024 1:43 PM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@xxxxxxxxxx>;
> patrick@xxxxxxxxx; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; Joel Stanley
> <joel@xxxxxxxxx>
> Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@xxxxxxxxx>;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-aspeed@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v1 2/5] ARM: dts: aspeed: yosemite4: remove led gpio
> pca9552 on fan boards
> 
>  [External Sender]
> 
>  [External Sender]
> 
> On Thu, 2024-09-26 at 11:28 +0800, Delphine CC Chiu wrote:
> > From: Ricky CX Wu <ricky.cx.wu.wiwynn@xxxxxxxxx>
> >
> > Remove led gpio contorller: pca9552 on fan boards since there is no
> > binding document for pca9552 currently.
> 
> That's not true, there is, just it's not converted to dt-schema:
> 
> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/t
> orvalds/linux.git/tree/Documentation/devicetree/bindings/leds/leds-pca955x.t
> xt?h=v6.11__;!!J63qqgXj!KJlZXg_GnpgYEsfLwrxkUEqwfsHkt_41jTnC09yd5VPAqT
> raqktY5p-KwUNQ3xPEbdockSD-knzTeOrQ8ijruq3-Q4c$
> 
> So the nodes can stay, though they probably generate warnings. The right way
> to fix this is to convert the binding document.
> 
> Andrew
> 
Hi Andrew,
Thanks for your suggestions.
I'll remain the nodes and provide the binding document in another patch.

Regards,
Ricky