Re: [PATCH] dt-bindings: net: can: atmel: Convert to json schema

[Charan.Pedumuru]

On 23/09/24 16:27, Marc Kleine-Budde wrote:
> On 20.09.2024 04:51:57,Charan.Pedumuru@xxxxxxxxxxxxx  wrote:
>>>> +allOf:
>>>> +  - $ref: can-controller.yaml#
>>>> +  - if:
>>>> +      properties:
>>>> +        compatible:
>>>> +          contains:
>>>> +            enum:
>>>> +              - microchip,sam9x60-can
>>>> +    then:
>>>> +      required:
>>>> +        - compatible
>>>> +        - reg
>>>> +        - interrupts
>>>> +        - clocks
>>>> +        - clock-names
>>> AFAICS clock-names is required for all compatibles.
>> In our case only sam9x60 is using clock-names property.
> No, the driver uses "clk_get(&pdev->dev, "can_clk")", so this property
> is mandatory.
Yes, what you said was correct, it was our mistake. I will remove the if 
statements and make
clocks and clock-names as default required properties. I will fix this 
in next revision.

>
> regards,
> Marc
>
> -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | 
> https://www.pengutronix.de | Vertretung Nürnberg | Phone: 
> +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: 
> +49-5121-206917-9 |


-- 
Best Regards,
Charan.