Re: [PATCH v3 2/3] staging: media: ipu3: Use str_down_up()

[Hans Verkuil]

On 28/09/2024 19:23, Ricardo Ribalda wrote:
> The str_down_up() helper simplifies the code and fixes the following cocci
> warning:
> 
> drivers/staging/media/ipu3/ipu3-css.c:229:18-47: opportunity for str_down_up(state & IMGU_STATE_POWER_DOWN)
> 
> Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>
> Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>

Acked-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>

> ---
>  drivers/staging/media/ipu3/ipu3-css.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/ipu3/ipu3-css.c b/drivers/staging/media/ipu3/ipu3-css.c
> index 1b0a59b78949..bb22375481a0 100644
> --- a/drivers/staging/media/ipu3/ipu3-css.c
> +++ b/drivers/staging/media/ipu3/ipu3-css.c
> @@ -226,7 +226,7 @@ int imgu_css_set_powerup(struct device *dev, void __iomem *base,
>  	state = readl(base + IMGU_REG_STATE);
>  
>  	dev_dbg(dev, "CSS pm_ctrl 0x%x state 0x%x (power %s)\n",
> -		pm_ctrl, state, state & IMGU_STATE_POWER_DOWN ? "down" : "up");
> +		pm_ctrl, state, str_down_up(state & IMGU_STATE_POWER_DOWN));
>  
>  	/* Power up CSS using wrapper */
>  	if (state & IMGU_STATE_POWER_DOWN) {
>