Re: [PATCH] function_graph: Simplify the initialization of fgraph LRU data
From: Liao, Chang
Date: Mon Sep 30 2024 - 03:17:55 EST
在 2024/9/28 8:17, Steven Rostedt 写道:
> On Thu, 12 Sep 2024 11:15:50 +0000
> Liao Chang <liaochang1@xxxxxxxxxx> wrote:
>
>> This patch uses [first ... last] = value to initialize fgraph_array[].
>> And it declares all the callbacks in fgraph_stub as static, as they are
>> not called from external code.
>
> This patch doesn't look like a simplification, and it is incorrect
> about the "not called from external code" as the kernel test robot
> pointed out!
Yes, I overlooked the external call, the static keyword is removed
in the next revision. The patch just makes code neat, it isn't a real
simplification.
>
> -- Steve
>
--
BR
Liao, Chang