Re: [PATCH v8 1/3] drm/bridge: synopsys: Add DW HDMI QP TX Controller support library
From: Maxime Ripard
Date: Mon Sep 30 2024 - 03:45:09 EST
On Sun, Sep 29, 2024 at 01:36:47AM GMT, Cristian Ciocaltea wrote:
> +static enum drm_mode_status
> +dw_hdmi_qp_bridge_mode_valid(struct drm_bridge *bridge,
> + const struct drm_display_info *info,
> + const struct drm_display_mode *mode)
> +{
> + struct dw_hdmi_qp *hdmi = bridge->driver_private;
> +
> + if (mode->clock > HDMI14_MAX_TMDSCLK / 1000) {
> + dev_dbg(hdmi->dev, "Unsupported mode clock: %d\n", mode->clock);
> + return MODE_CLOCK_HIGH;
> + }
Similarly, you should use drm_hdmi_compute_mode_clock here, with RGB and 8bpc
Once fixed,
Reviewed-by: Maxime Ripard <mripard@xxxxxxxxxx>
Maxime
Attachment:
signature.asc
Description: PGP signature