[PATCH v2] Fix NULL pointer dereference in read_cache_folio

From: Gianfranco Trad
Date: Mon Sep 30 2024 - 05:06:56 EST


Add check on filler to prevent NULL pointer dereference condition in
read_cache_folio[1].

[1] https://syzkaller.appspot.com/bug?extid=4089e577072948ac5531

Reported-by: syzbot+4089e577072948ac5531@xxxxxxxxxxxxxxxxxxxxxxxxx
Closes: https://syzkaller.appspot.com/bug?extid=4089e577072948ac5531
Tested-by: syzbot+4089e577072948ac5531@xxxxxxxxxxxxxxxxxxxxxxxxx
Signed-off-by: Gianfranco Trad <gianf.trad@xxxxxxxxx>
---

Notes:
changes in v2:
- refactored check on filler.

mm/filemap.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/mm/filemap.c b/mm/filemap.c
index 4f3753f0a158..88de8029133c 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -2360,6 +2360,8 @@ static int filemap_read_folio(struct file *file, filler_t filler,
/* Start the actual read. The read will unlock the page. */
if (unlikely(workingset))
psi_memstall_enter(&pflags);
+ if (!filler)
+ return -EIO;
error = filler(file, folio);
if (unlikely(workingset))
psi_memstall_leave(&pflags);
--
2.43.0