Re: [PATCH] Input: adp5588-keys - Added checking of key and key_val variables

[Nuno Sá]

On Mon, 2024-09-30 at 11:36 +0300, Denis Arefev wrote:
> If the adp5588_read function returns 0, then there will be an
> overflow of the kpad->keycode buffer.
> 
> If the adp5588_read function returns a negative value, then the
> logic is broken - the wrong value is used as an index of
> the kpad->keycode array.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Cc: stable@xxxxxxxxxxxxxxx # v5.10+
> Signed-off-by: Denis Arefev <arefev@xxxxxxxxx>
> ---

Hi Denis,

Thanks for the patch. However, I'm working on a more complete rework of this as
suggested in [1]. I should be sending patches for it today or tomorrow.

[1]: https://lore.kernel.org/linux-input/Zu0vq0ogr2HzXWv7@xxxxxxxxxx/
- Nuno Sá