Re: [PATCH v1 2/2] selftests/mm: hugetlb_fault_after_madv: improve test output

[Breno Leitao]

On Thu, Sep 26, 2024 at 05:20:44PM +0200, David Hildenbrand wrote:
> Let's improve the test output. For example, print the proper test
> result. Install a SIGBUS handler to catch any SIGBUS instead of
> crashing the test on failure.

That is way better now. Thanks for improving it.

> With unsuitable hugetlb page count:
>   $ ./hugetlb_fault_after_madv
>   TAP version 13
>   1..1
>   # [INFO] detected default hugetlb page size: 2048 KiB
>   ok 2 # SKIP This test needs one and only one page to execute. Got 0
>   # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:1 error:0
> 
> On a failure:
>   $ ./hugetlb_fault_after_madv
>   TAP version 13
>   1..1
>   not ok 1 SIGBUS behavior
>   Bail out! 1 out of 1 tests failed
> 
> On success:
>   $ ./hugetlb_fault_after_madv
>   TAP version 13
>   1..1
>   # [INFO] detected default hugetlb page size: 2048 KiB
>   ok 1 SIGBUS behavior
>   # Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0
> 
> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>

Reviewed-by: Breno Leitao <leitao@xxxxxxxxxx>