Re: [PATCH 3/3] arm64: dts: exynosautov920: add watchdog DT node

From: Krzysztof Kozlowski
Date: Mon Sep 30 2024 - 07:43:10 EST


On 13/09/2024 10:03, Taewan Kim wrote:
> From: Byoungtae Cho <bt.cho@xxxxxxxxxxx>
>
> Adds two watchdog devices for ExynosAutoV920 SoC.
>
> Signed-off-by: Byoungtae Cho <bt.cho@xxxxxxxxxxx>
> Signed-off-by: Taewan Kim <trunixs.kim@xxxxxxxxxxx>
> ---
> .../arm64/boot/dts/exynos/exynosautov920.dtsi | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> index c1c8566d74f5..de210f8e5599 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> @@ -297,6 +297,26 @@ pinctrl_aud: pinctrl@1a460000 {
> compatible = "samsung,exynosautov920-pinctrl";
> reg = <0x1a460000 0x10000>;
> };
> +
> + watchdog_cl0: watchdog@10060000 {

Does not look like placed in correct location. 1a46 > 1006. Please
follow DTS coding style in all your works.

Best regards,
Krzysztof