[PATCH] w1: Use kfree_sensitive() instead of memset(0) and kfree()
From: Thorsten Blum
Date: Mon Sep 30 2024 - 07:44:58 EST
Use kfree_sensitive() to simplify w1_unref_slave() and remove the
following Coccinelle/coccicheck warning reported by
kfree_sensitive.cocci:
WARNING opportunity for kfree_sensitive/kvfree_sensitive
Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
---
Please note: this change assumes that #ifdef DEBUG is no longer needed
and we should always zero out the memory.
---
drivers/w1/w1.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index d82e86d3ddf6..127694180eb8 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -795,10 +795,7 @@ int w1_unref_slave(struct w1_slave *sl)
w1_family_notify(BUS_NOTIFY_DEL_DEVICE, sl);
device_unregister(&sl->dev);
- #ifdef DEBUG
- memset(sl, 0, sizeof(*sl));
- #endif
- kfree(sl);
+ kfree_sensitive(sl);
}
atomic_dec(&dev->refcnt);
mutex_unlock(&dev->list_mutex);
--
2.46.2