Re: [PATCH v2 1/1] device: rust: change the name function
From: Greg KH
Date: Mon Sep 30 2024 - 09:01:24 EST
On Mon, Sep 30, 2024 at 09:39:56AM -0300, Guilherme Giacomo Simoes wrote:
> This function increment the refcount by this command "bindings::get_device(prt)".
> This can be confuse becuase, the function Arc::from_raw() from standard library, don't increment the refcount.
> Then, this function "Device::from_raw()" will be renamed for don't make confusing in the future.
Your editor should have asked you to wrap these at 72 columns, can you
please do that?
>
> Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@xxxxxxxxx>
> ---
> rust/kernel/device.rs | 2 +-
> rust/kernel/firmware.rs | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
What changed from v1? That should go under the --- line.
thanks,
greg k-h