Re: [linux][PATCH v2 08/20] dt-bindings: clock: mpfs-clkcfg: Add PIC64GX compatibility

From: Conor Dooley
Date: Mon Sep 30 2024 - 09:48:01 EST


On Mon, Sep 30, 2024 at 10:54:37AM +0100, pierre-henry.moussay@xxxxxxxxxxxxx wrote:
> From: Pierre-Henry Moussay <pierre-henry.moussay@xxxxxxxxxxxxx>
>
> PIC64GX has a clock controller compatible whith mpfs-clkcfg

NAK, v1 comments need to be addressed before this can be done.

>
> Signed-off-by: Pierre-Henry Moussay <pierre-henry.moussay@xxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/clock/microchip,mpfs-clkcfg.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/microchip,mpfs-clkcfg.yaml b/Documentation/devicetree/bindings/clock/microchip,mpfs-clkcfg.yaml
> index e4e1c31267d2..ca889f5df87a 100644
> --- a/Documentation/devicetree/bindings/clock/microchip,mpfs-clkcfg.yaml
> +++ b/Documentation/devicetree/bindings/clock/microchip,mpfs-clkcfg.yaml
> @@ -19,7 +19,11 @@ description: |
>
> properties:
> compatible:
> - const: microchip,mpfs-clkcfg
> + oneOf:
> + - items:
> + - const: microchip,pic64gx-clkcfg
> + - const: microchip,mpfs-clkcfg
> + - const: microchip,mpfs-clkcfg
>
> reg:
> items:
> --
> 2.30.2
>
>

Attachment: signature.asc
Description: PGP signature