Re: [PATCH v2 15/16] media: renesas: rzg2l-cru: Refactor ICnDMR register configuration

[Lad, Prabhakar]

Hi Laurent,

Thank you for the review.

On Sat, Sep 28, 2024 at 12:21 AM Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> Thank you for the patch.
>
> On Tue, Sep 10, 2024 at 06:53:56PM +0100, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Refactor the ICnDMR register configuration in
> > `rzg2l_cru_initialize_image_conv()` by adding a new member `icndmr` in the
> > `rzg2l_cru_ip_format` structure. This change introduces a new function
> > `rzg2l_cru_ip_pix_fmt_to_icndmr()` to map the pixel format to its
> > corresponding ICnDMR value.
>
> Skip this new function, use the function thar returns a
> rzg2l_cru_ip_format pointer, and access the icndmr field from there.
> rzg2l_cru_initialize_image_conv() already gets the format info pointer,
> so the code will be simpler and more efficient.
>
Agreed.

> >
> > Suggested-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > ---
> >  drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h |  5 +++++
> >  drivers/media/platform/renesas/rzg2l-cru/rzg2l-ip.c  | 12 ++++++++++++
> >  .../media/platform/renesas/rzg2l-cru/rzg2l-video.c   | 10 ++++------
> >  3 files changed, 21 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> > index 24097df14881..3da9e8e7025a 100644
> > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-cru.h
> > @@ -31,6 +31,8 @@
> >  #define RZG2L_CRU_MIN_INPUT_HEIGHT   240
> >  #define RZG2L_CRU_MAX_INPUT_HEIGHT   4095
> >
> > +#define ICnDMR_YCMODE_UYVY           (1 << 4)
>
> Not a candidate for this patch, but I would recommend moving all the
> register definitions to this file, or to a rzg2l-cru-regs.h file.
>
OK, I'll create a new patch to move all reg defs to rzg2l-cru-regs.h file.

Cheers,
Prabhakar