Re: linux-6.12-rc1/drivers/iio/imu/bmi323/bmi323_core.c:133: Array contents defined but not used ?

[Denis Benato]

Il 30 settembre 2024 16:19:14 CEST, Lars-Peter Clausen <lars@xxxxxxxxxx> ha scritto:
>On 9/30/24 06:49, David Binderman wrote:
>> Hello there,
>> 
>> I just tried to build linux-6.12-rc1 with clang. It said:
>> 
>> drivers/iio/imu/bmi323/bmi323_core.c:133:27: warning: variable 'bmi323_ext_reg_savestate' is not needed and will not be emitted [-Wunneeded-internal-declaration]
>> 
>> A grep for the identifier shows the following strange results::
>> 
>> inux-6.12-rc1 $ grep bmi323_ext_reg_savestate drivers/iio/imu/bmi323/bmi323_core.c
>> static const unsigned int bmi323_ext_reg_savestate[] = {
>> 	unsigned int ext_reg_settings[ARRAY_SIZE(bmi323_ext_reg_savestate)];
>> 	for (unsigned int i = 0; i < ARRAY_SIZE(bmi323_ext_reg_savestate); i++) {
>> 	for (unsigned int i = 0; i < ARRAY_SIZE(bmi323_ext_reg_savestate); i++) {
>> linux-6.12-rc1 $
>> 
>> I see no mention of bmi323_ext_reg_savestate[ i]. Is there a possible
>> cut'n'paste error in one of the two for loops ?
>Yes. Do you want to send a fix?
>
Hello,

I think fixes are pending already in one of Jonathan Cameron's branches.

Best regards,
Denis Benato