Re: [PATCH v2 4/5] drm/msm/dpu: Add SA8775P support

[Mahadevan P]

On 9/26/2024 6:39 PM, Dmitry Baryshkov wrote:
> On Thu, Sep 26, 2024 at 04:31:36PM GMT, Mahadevan wrote:
> > Add definitions for the display hardware used on the
> > Qualcomm SA8775P platform.
> >
> > Signed-off-by: Mahadevan <quic_mahap@xxxxxxxxxxx>
> > ---
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
>
> Minor nit below.
>
> > [v2]
> > - Reorder compatible string of DPU based on alphabetical order.[Dmitry]
> >
> > ---
> >   .../msm/disp/dpu1/catalog/dpu_8_4_sa8775p.h   | 485 ++++++++++++++++++
> >   .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c    |   3 +-
> >   .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h    |   3 +-
> >   drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c       |   3 +-
> >   4 files changed, 491 insertions(+), 3 deletions(-)
> >   create mode 100644 drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_4_sa8775p.h
> >
> > diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_4_sa8775p.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_4_sa8775p.h
> > new file mode 100644
> > index 000000000000..14d65b5d4093
> > --- /dev/null
> > +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_4_sa8775p.h
> > @@ -0,0 +1,485 @@
> > +/* SPDX-License-Identifier: GPL-2.0-only */
> > +/*
> > + * Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved.
> > + * Copyright (c) 2015-2018, 2020 The Linux Foundation. All rights reserved.
> What exactly is copyrighted by LF?


LF copyright is not needed.

Thanks for pointing out the copyrights in other files too. Will update 
in subsequent patch.


> > + */
> > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> > index dcb4fd85e73b..6f60fff2c9a6 100644
> > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> > @@ -1,6 +1,6 @@
> >   // SPDX-License-Identifier: GPL-2.0-only
> >   /* Copyright (c) 2015-2018, The Linux Foundation. All rights reserved.
> > - * Copyright (c) 2022-2023, Qualcomm Innovation Center, Inc. All rights reserved.
> > + * Copyright (c) 2022-2024, Qualcomm Innovation Center, Inc. All rights reserved.
> I am not a lawyer, but I don't think a single #include is copyrightable.
> Neither are single data lines in other files.
>
> >    */
> >   
> >   #define pr_fmt(fmt)	"[drm:%s:%d] " fmt, __func__, __LINE__
> > @@ -699,6 +699,7 @@ static const struct dpu_qos_lut_entry sc7180_qos_nrt[] = {
> >   
> >   #include "catalog/dpu_8_0_sc8280xp.h"
> >   #include "catalog/dpu_8_1_sm8450.h"
> > +#include "catalog/dpu_8_4_sa8775p.h"
> >   
> >   #include "catalog/dpu_9_0_sm8550.h"
> >   
> > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
> > index 37e18e820a20..cff16dcf277f 100644
> > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
> > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
> > @@ -1,6 +1,6 @@
> >   /* SPDX-License-Identifier: GPL-2.0-only */
> >   /*
> > - * Copyright (c) 2022-2023, Qualcomm Innovation Center, Inc. All rights reserved.
> > + * Copyright (c) 2022-2024, Qualcomm Innovation Center, Inc. All rights reserved.
> >    * Copyright (c) 2015-2018, 2020 The Linux Foundation. All rights reserved.
> >    */
> >   
> > @@ -850,6 +850,7 @@ extern const struct dpu_mdss_cfg dpu_sm8350_cfg;
> >   extern const struct dpu_mdss_cfg dpu_sc7280_cfg;
> >   extern const struct dpu_mdss_cfg dpu_sc8280xp_cfg;
> >   extern const struct dpu_mdss_cfg dpu_sm8450_cfg;
> > +extern const struct dpu_mdss_cfg dpu_sa8775p_cfg;
> >   extern const struct dpu_mdss_cfg dpu_sm8550_cfg;
> >   extern const struct dpu_mdss_cfg dpu_sm8650_cfg;
> >   extern const struct dpu_mdss_cfg dpu_x1e80100_cfg;
> > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> > index 9bcae53c4f45..16a0b417435e 100644
> > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> > @@ -2,7 +2,7 @@
> >   /*
> >    * Copyright (C) 2013 Red Hat
> >    * Copyright (c) 2014-2018, The Linux Foundation. All rights reserved.
> > - * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
> > + * Copyright (c) 2022, 2024 Qualcomm Innovation Center, Inc. All rights reserved.
> >    *
> >    * Author: Rob Clark <robdclark@xxxxxxxxx>
> >    */
> > @@ -1447,6 +1447,7 @@ static const struct dev_pm_ops dpu_pm_ops = {
> >   static const struct of_device_id dpu_dt_match[] = {
> >   	{ .compatible = "qcom,msm8998-dpu", .data = &dpu_msm8998_cfg, },
> >   	{ .compatible = "qcom,qcm2290-dpu", .data = &dpu_qcm2290_cfg, },
> > +	{ .compatible = "qcom,sa8775p-dpu", .data = &dpu_sa8775p_cfg, },
> >   	{ .compatible = "qcom,sdm630-mdp5", .data = &dpu_sdm630_cfg, },
> >   	{ .compatible = "qcom,sdm660-mdp5", .data = &dpu_sdm660_cfg, },
> >   	{ .compatible = "qcom,sdm670-dpu", .data = &dpu_sdm670_cfg, },
> > --
> > 2.34.1