Re: [PATCH] irqchip/renesas-rzg2l: Fix missing put_device

From: Marc Zyngier
Date: Mon Sep 30 2024 - 11:50:46 EST


On Mon, 30 Sep 2024 15:55:39 +0100,
Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx> wrote:
>
> rzg2l_irqc_common_init calls of_find_device_by_node, but the
> corresponding put_device call is missing.
>
> Make sure we call put_device both when failing and when
> succeeding.

What sort of lifetime are you trying to enforce?

It looks to me that you'd be better off doing *one* device_put() right
after you have found the parent domain, but that completely depends on
the above.

Thanks,

M.

--
Without deviation from the norm, progress is not possible.