Re: [PATCH net-next] selftests: net: csum: Clean up recv_verify_packet_ipv6

[Willem de Bruijn]

Sean Anderson wrote:
> On 9/30/24 13:16, Willem de Bruijn wrote:
> > Sean Anderson wrote:
> >> Rename ip_len to payload_len since the length in this case refers only
> >> to the payload, and not the entire IP packet like for IPv4. While we're
> >> at it, just use the variable directly when calling
> >> recv_verify_packet_udp/tcp.
> >> 
> >> Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxxx>
> > 
> > Not sure such refactoring patches are worth the effort.
> 
> Well, FWIW you commented on this in your review, so I figured I'd send it.
> 
> https://lore.kernel.org/all/66dbb4fcbf560_2af86229423@xxxxxxxxxxxxxxxxxxxxxx.notmuch/

True. I meant if respun.

Whether such changes are worth it as standalone patch is subjective.
And I get where you're coming from, given that thread.

Reviewed-by: Willem de Bruijn <willemb@xxxxxxxxxx>