Re: [PATCH net v5] net: systemport: Add error pointer checks in bcm_sysport_map_queues() and bcm_sysport_unmap_queues()
From: Dipendra Khadka
Date: Tue Oct 01 2024 - 00:37:38 EST
Hi,
On Tue, 1 Oct 2024 at 02:17, Vladimir Oltean <vladimir.oltean@xxxxxxx> wrote:
>
> On Mon, Sep 30, 2024 at 11:52:45PM +0545, Dipendra Khadka wrote:
> > > And why is the author of the blamed patch even CCed only at v5?!
> >
> > Sorry to know this, I ran the script and there I did not find your name.
> >
> > ./scripts/get_maintainer.pl drivers/net/ethernet/broadcom/bcmsysport.c
> > Florian Fainelli <florian.fainelli@xxxxxxxxxxxx> (supporter:BROADCOM SYSTEMPORT ETHERNET DRIVER)
> > Broadcom internal kernel review list <bcm-kernel-feedback-list@xxxxxxxxxxxx> (reviewer:BROADCOM SYSTEMPORT ETHERNET DRIVER)
> > "David S. Miller" <davem@xxxxxxxxxxxxx> (maintainer:NETWORKING DRIVERS)
> > Eric Dumazet <edumazet@xxxxxxxxxx> (maintainer:NETWORKING DRIVERS)
> > Jakub Kicinski <kuba@xxxxxxxxxx> (maintainer:NETWORKING DRIVERS)
> > Paolo Abeni <pabeni@xxxxxxxxxx> (maintainer:NETWORKING DRIVERS)
> > netdev@xxxxxxxxxxxxxxx (open list:BROADCOM SYSTEMPORT ETHERNET DRIVER)
> > linux-kernel@xxxxxxxxxxxxxxx (open list)
>
> It's in the question you ask. Am I a maintainer of bcmsysport? No, and
> I haven't made significant contributions on it either. But if you run
> get_maintainer.pl on the _patch_ file that you will run through git
> send-email, my name will be listed (the "--fixes" option defaults to 1).
>
Oh, thank you for this. I only used to run get_maintainers.pl on the
file which got changed. I will run on the patch file as well from now.
> The netdev CI also runs get_maintainers.pl on the actual patch, and that
> triggers one of its red flags: "1 blamed authors not CCed: vladimir.oltean@xxxxxxx"
> https://patchwork.kernel.org/project/netdevbpf/patch/20240926160513.7252-1-kdipendra88@xxxxxxxxx/
Best regards,
Dipendra Khadka