RE: [PATCH net-next] net: phy: microchip_t1: Interrupt support for lan887x

[Divya.Koppera]

Hi Andrew,

Thanks for the review comments, I will apply it in next revision.

/Divya

> -----Original Message-----
> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: Monday, September 30, 2024 10:14 PM
> To: Divya Koppera - I30481 <Divya.Koppera@xxxxxxxxxxxxx>
> Cc: Arun Ramadoss - I17769 <Arun.Ramadoss@xxxxxxxxxxxxx>;
> UNGLinuxDriver <UNGLinuxDriver@xxxxxxxxxxxxx>; hkallweit1@xxxxxxxxx;
> linux@xxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx;
> kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH net-next] net: phy: microchip_t1: Interrupt support for
> lan887x
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> > +static int lan887x_config_intr(struct phy_device *phydev) {
> > +     int ret;
> 
> This driver consistently uses rc, not ret. It would be good to keep with the
> existing convention.
> 
>     Andrew
> 
> ---
> pw-bot: cr