Re: [PATCH] spi: atmel-quadspi: Fix wrong register value written to MR

[Alexander Dahl]

Hei hei,

Am Thu, Sep 26, 2024 at 11:03:56AM +0200 schrieb Alexander Dahl:
> aq->mr should go to MR, nothing else.
> 
> Fixes: 329ca3eed4a9 ("spi: atmel-quadspi: Avoid overwriting delay register settings")
> Signed-off-by: Alexander Dahl <ada@xxxxxxxxxxx>
> Link: https://lore.kernel.org/linux-spi/20240926-macarena-wincing-7c4995487a29@xxxxxxxxxxx/T/#u

I've seen the faulty patch 329ca3eed4a9 ("spi: atmel-quadspi: Avoid
overwriting delay register settings") gone not only to master where it
should be fixed before v6.12, but also to stable queue for 6.11,
6.10, and 6.6 so this fixup should go there too, right?

Greets
Alex

> ---
> 
> Notes:
>     based on today's master
> 
>  drivers/spi/atmel-quadspi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
> index 4f288f07e38f..95cdfc28361e 100644
> --- a/drivers/spi/atmel-quadspi.c
> +++ b/drivers/spi/atmel-quadspi.c
> @@ -377,7 +377,7 @@ static int atmel_qspi_set_cfg(struct atmel_qspi *aq,
>  	 */
>  	if (!(aq->mr & QSPI_MR_SMM)) {
>  		aq->mr |= QSPI_MR_SMM;
> -		atmel_qspi_write(aq->scr, aq, QSPI_MR);
> +		atmel_qspi_write(aq->mr, aq, QSPI_MR);
>  	}
>  
>  	/* Clear pending interrupts */
> 
> base-commit: 11a299a7933e03c83818b431e6a1c53ad387423d
> -- 
> 2.39.5
> 
>