Re: [PATCH 2/2] arm64: dts: qcom: Add X1E001DE Snapdragon Devkit for Windows

[Dmitry Baryshkov]

On October 1, 2024 5:42:35 AM GMT+03:00, Bjorn Andersson <andersson@xxxxxxxxxx> wrote:
>On Wed, Sep 11, 2024 at 10:55:05AM GMT, Dmitry Baryshkov wrote:
>> On Wed, Sep 11, 2024 at 01:03:37PM GMT, Sibi Sankar wrote:
>[..]
>> > diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
>[..]
>> > +
>> > +&pcie5 {
>> > +	perst-gpios = <&tlmm 149 GPIO_ACTIVE_LOW>;
>> > +	wake-gpios = <&tlmm 151 GPIO_ACTIVE_LOW>;
>> > +
>> > +	vddpe-3v3-supply = <&vreg_wwan>;
>> 
>> Please use pwrseq instead.
>> 
>
>What benefit is there to wrap a single 3.3V regulator in pwrseq driver?

First of all, is it really just a 3.3V? Second, is it actually powering up the host controller (as expressed in the device tree? Is it a power supply to the slot (in this case, I think, it should be expressed differently)? Or is it a power supply to the card itself?


>
>> > +
>> > +	pinctrl-0 = <&pcie5_default>;
>> > +	pinctrl-names = "default";
>> > +
>> > +	status = "okay";
>> > +};
>> > +
>> > +&pcie5_phy {
>> > +	vdda-phy-supply = <&vreg_l3i_0p8>;
>> > +	vdda-pll-supply = <&vreg_l3e_1p2>;
>> > +
>> > +	status = "okay";
>> > +};
>> > +
>> > +&pcie6a {
>> > +	perst-gpios = <&tlmm 152 GPIO_ACTIVE_LOW>;
>> > +	wake-gpios = <&tlmm 154 GPIO_ACTIVE_LOW>;
>> > +
>> > +	vddpe-3v3-supply = <&vreg_nvme>;
>> 
>> Please use pwrseq instead.
>> 
>
>Ditto


Same set of questions.

>
>Regards,
>Bjorn


-- 
With best wishes
Dmitry