Re: [PATCH v2 2/3] dt-bindings: mfd: twl: add charger node also for TWL603x

[Krzysztof Kozlowski]

On Mon, Sep 30, 2024 at 05:54:03PM +0200, Andreas Kemnade wrote:
> Also the TWL603X devices have a charger, so allow to specify it here.
> 
> Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/mfd/ti,twl.yaml       | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/ti,twl.yaml b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> index e94b0fd7af0f8..488d419b211d1 100644
> --- a/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> +++ b/Documentation/devicetree/bindings/mfd/ti,twl.yaml
> @@ -105,6 +105,12 @@ allOf:
>              regulator-initial-mode: false
>  
>        properties:
> +        charger:

Properties should be defined in top-level, mot in allOf. You can
disallow them for certain variants.

Best regards,
Krzysztof