Re: [PATCHv5 3/7] zram: rework recompress target selection strategy

[Dan Carpenter]

On Tue, Sep 17, 2024 at 11:09:08AM +0900, Sergey Senozhatsky wrote:
> +static struct zram_pp_slot *select_pp_slot(struct zram_pp_ctl *ctl)
> +{
> +	struct zram_pp_slot *pps = NULL;
> +	s32 idx = NUM_PP_BUCKETS - 1;
> +
> +	/* The higher the bucket id the more optimal slot post-processing is */
> +	while (idx > 0) {

Why is this not idx >= 0?  Why skip the first bucket?

regards,
dan carpenter

> +		pps = list_first_entry_or_null(&ctl->pp_buckets[idx],
> +					       struct zram_pp_slot,
> +					       entry);
> +		if (pps)
> +			break;
> +
> +		idx--;
> +	}
> +	return pps;
> +}