Re: [PATCH net-next 09/13] net: ibm: emac: rgmii: devm_platform_get_resource
From: kernel test robot
Date: Tue Oct 01 2024 - 04:25:16 EST
Hi Rosen,
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Rosen-Penev/net-ibm-emac-remove-custom-init-exit-functions/20241001-020553
base: net-next/main
patch link: https://lore.kernel.org/r/20240930180036.87598-10-rosenp%40gmail.com
patch subject: [PATCH net-next 09/13] net: ibm: emac: rgmii: devm_platform_get_resource
config: powerpc-fsp2_defconfig (https://download.01.org/0day-ci/archive/20241001/202410011636.QtBtiUKi-lkp@xxxxxxxxx/config)
compiler: powerpc-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241001/202410011636.QtBtiUKi-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410011636.QtBtiUKi-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
drivers/net/ethernet/ibm/emac/rgmii.c: In function 'rgmii_probe':
>> drivers/net/ethernet/ibm/emac/rgmii.c:229:21: error: implicit declaration of function 'devm_platform_get_resource'; did you mean 'platform_get_resource'? [-Wimplicit-function-declaration]
229 | dev->base = devm_platform_get_resource(ofdev, 0);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| platform_get_resource
>> drivers/net/ethernet/ibm/emac/rgmii.c:229:19: error: assignment to 'struct rgmii_regs *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
229 | dev->base = devm_platform_get_resource(ofdev, 0);
| ^
vim +229 drivers/net/ethernet/ibm/emac/rgmii.c
215
216
217 static int rgmii_probe(struct platform_device *ofdev)
218 {
219 struct rgmii_instance *dev;
220
221 dev = devm_kzalloc(&ofdev->dev, sizeof(struct rgmii_instance),
222 GFP_KERNEL);
223 if (!dev)
224 return -ENOMEM;
225
226 mutex_init(&dev->lock);
227 dev->ofdev = ofdev;
228
> 229 dev->base = devm_platform_get_resource(ofdev, 0);
230 if (IS_ERR(dev->base)) {
231 dev_err(&ofdev->dev, "can't map device registers");
232 return PTR_ERR(dev->base);
233 }
234
235 /* Check for RGMII flags */
236 if (of_property_read_bool(ofdev->dev.of_node, "has-mdio"))
237 dev->flags |= EMAC_RGMII_FLAG_HAS_MDIO;
238
239 /* CAB lacks the right properties, fix this up */
240 if (of_device_is_compatible(ofdev->dev.of_node, "ibm,rgmii-axon"))
241 dev->flags |= EMAC_RGMII_FLAG_HAS_MDIO;
242
243 DBG2(dev, " Boot FER = 0x%08x, SSR = 0x%08x\n",
244 in_be32(&dev->base->fer), in_be32(&dev->base->ssr));
245
246 /* Disable all inputs by default */
247 out_be32(&dev->base->fer, 0);
248
249 printk(KERN_INFO
250 "RGMII %pOF initialized with%s MDIO support\n",
251 ofdev->dev.of_node,
252 (dev->flags & EMAC_RGMII_FLAG_HAS_MDIO) ? "" : "out");
253
254 wmb();
255 platform_set_drvdata(ofdev, dev);
256
257 return 0;
258 }
259
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki