Re: [PATCH v7 0/2] Improve VM CPUfreq and task placement behavior

From: Viresh Kumar
Date: Tue Oct 01 2024 - 05:26:00 EST


On 18-09-24, 17:08, David Dai wrote:
> Hi,
>
> This patch series is a continuation of the talk Saravana gave at LPC 2022
> titled "CPUfreq/sched and VM guest workload problems" [1][2][3]. The gist
> of the talk is that workloads running in a guest VM get terrible task
> placement and CPUfreq behavior when compared to running the same workload
> in the host. Effectively, no EAS(Energy Aware Scheduling) for threads
> inside VMs. This would make power and performance terrible just by running
> the workload in a VM even if we assume there is zero virtualization
> overhead.

> David Dai (2):
> dt-bindings: cpufreq: add virtual cpufreq device
> cpufreq: add virtual-cpufreq driver
>
> .../cpufreq/qemu,virtual-cpufreq.yaml | 48 +++
> drivers/cpufreq/Kconfig | 14 +
> drivers/cpufreq/Makefile | 1 +
> drivers/cpufreq/virtual-cpufreq.c | 333 ++++++++++++++++++
> include/linux/arch_topology.h | 1 +
> 5 files changed, 397 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/cpufreq/qemu,virtual-cpufreq.yaml
> create mode 100644 drivers/cpufreq/virtual-cpufreq.c

LGTM.

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh