Re: [PATCH v2 2/2] drm/panel: simple: Add Microchip AC69T88A LVDS Display panel

[Manikandan.M]

On 27/09/24 4:51 am, Dmitry Baryshkov wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Thu, Sep 26, 2024 at 03:58:11PM GMT, Maxime Ripard wrote:
>> On Thu, Sep 26, 2024 at 04:32:59PM GMT, Dmitry Baryshkov wrote:
>>> On Thu, Sep 26, 2024 at 08:17:09AM GMT, Manikandan.M@xxxxxxxxxxxxx wrote:
>>>> On 23/09/24 11:37 am, Dmitry Baryshkov wrote:
>>>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>>>
>>>>> On Mon, Sep 23, 2024 at 05:50:22AM GMT, Manikandan.M@xxxxxxxxxxxxx wrote:
>>>>>> On 20/09/24 9:13 pm, Dmitry Baryshkov wrote:
>>>>>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>>>>>
>>>>>>> On Thu, Sep 19, 2024 at 02:45:48PM GMT, Manikandan Muralidharan wrote:
>>>>>>>> Add support for Microchip AC69T88A 5 inch TFT LCD 800x480
>>>>>>>> Display module with LVDS interface.The panel uses the Sitronix
>>>>>>>> ST7262 800x480 Display driver
>>>>>>>
>>>>>>> AC69T88A seems to be a module name, rather than a panel name. What is
>>>>>>> the actual panel name present on this module?
>>>>>> Both names, "Microchip AC69T88A" and "MPU32-LVDS-DISPLAY-WVGA" are
>>>>>> present on the display module
>>>>>
>>>>> Which panel was used for the module? I don't think that Microchip
>>>>> produces LVDS panels.
>>>> Its a new LVDS display from Microchip that uses Sitronix ST7262 TFT LCD
>>>> driver
>>>>
>>>> https://www.crystalfontz.com/controllers/datasheet-viewer.php?id=486
>>>
>>> Ok. Anyway if somebody ends up looking for the panel, they'll probably
>>> find the module and vice versa.
>>>
>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
>>
>> Given that aside from that mail, the module name isn't mentionned
>> anywhere, I'm not sure they would.
>>
>> The way we usually deal with controllers is to have a separate driver
>> for panels based on that controller, even more so since that controller
>> seems to be able to affect the display.
> 
> But in this case it's panel-simple, no special driver for the
> controller. From my understanding the AC69T88A is the module name (at
> least the datasheet uses that name). The on-board EEPROM also carries
> that name and the name of the controller.
Yes, as per the proposed on-board EEPROM spec, it holds the module name 
and the LCD driver used.
> 
> --
> With best wishes
> Dmitry

-- 
Thanks and Regards,
Manikandan M.