Re: [PATCH net v2] ip6mr: Fix lockdep and sparse RCU warnings

From: Eric Dumazet
Date: Tue Oct 01 2024 - 06:34:51 EST


On Tue, Oct 1, 2024 at 12:05 PM Stefan Wiehler <stefan.wiehler@xxxxxxxxx> wrote:
>
> ip6mr_vif_seq_start() must lock RCU even in a case of error, because
> stop callback is called unconditionally.
>

OK, but RT6_TABLE_DFLT always exists, ip6mr_get_table(net, RT6_TABLE_DFLT)
can never fail.

This is ensured at netns creation, from ip6mr_rules_init()

This complex patch adds some code churn, with no clear bug fix ?