Re: [PATCH 1/3] gpio: xilinx: drop dependency on GPIO_OF

[Bartosz Golaszewski]

On Tue, Oct 1, 2024 at 12:30 PM Michal Simek <michal.simek@xxxxxxx> wrote:
>
> On 9/30/24 16:48, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> >
> > This driver doesn't really depend on gpiolib-of being built and can be
> > compiled without it.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> > ---
> >   drivers/gpio/Kconfig | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> > index d93cd4f722b4..0d676c96b72d 100644
> > --- a/drivers/gpio/Kconfig
> > +++ b/drivers/gpio/Kconfig
> > @@ -796,7 +796,6 @@ config GPIO_XGENE_SB
> >   config GPIO_XILINX
> >       tristate "Xilinx GPIO support"
> >       select GPIOLIB_IRQCHIP
> > -     depends on OF_GPIO
> >       help
> >         Say yes here to support the Xilinx FPGA GPIO device.
> >
>
> The patch itself is fine but it should be likely applied as last one not the
> first one.
> If this is applied like that feel free to add
>
> Acked-by: Michal Simek <michal.simek@xxxxxxx>
>

I think you may be confusing CONFIG_OF with CONFIG_OF_GPIO. This
driver doesn't depend at build-time on the latter and this patch can
be applied right away.

Bart