Re: [PATCH] printk: Fix signed integer overflow when defining LOG_BUF_LEN_MAX

[Petr Mladek]

On Sat 2024-09-28 19:36:08, Kuan-Wei Chiu wrote:
> Shifting 1 << 31 on a 32-bit int causes signed integer overflow, which
> leads to undefined behavior. To prevent this, cast 1 to u32 before
> performing the shift, ensuring well-defined behavior.
> 
> This change explicitly avoids any potential overflow by ensuring that
> the shift occurs on an unsigned 32-bit integer.
> 
> Signed-off-by: Kuan-Wei Chiu <visitorckw@xxxxxxxxx>

Looks good to me.

Acked-by: Petr Mladek <pmladek@xxxxxxxx>

Best Regards,
Petr