Re: [PATCH v1 1/2] s390/uv: Refactor uv-sysfs creation

[Janosch Frank]

On 9/30/24 3:20 PM, Steffen Eiden wrote:
> Streamline the sysfs generation to make it more extensible.
> Add a function to create a sysfs entry in the uv-sysfs dir.
> Use this function for the query directory.
>
> Reviewed-by: Christoph Schlameuss <schlameuss@xxxxxxxxxxxxx>
> Signed-off-by: Steffen Eiden <seiden@xxxxxxxxxxxxx>

Reviewed-by: Janosch Frank <frankja@xxxxxxxxxxxxx>


> @@ -767,17 +786,11 @@ static int __init uv_info_init(void)
>   	if (rc)
>   		goto out_kobj;
>   
> -	uv_query_kset = kset_create_and_add("query", NULL, uv_kobj);
> -	if (!uv_query_kset) {
> -		rc = -ENOMEM;
> +	rc = uv_sysfs_dir_init(&uv_query_attr_group, &uv_query_kset, "query");
> +	if (rc)
>   		goto out_ind_files;
> -	}
> -
> -	rc = sysfs_create_group(&uv_query_kset->kobj, &uv_query_attr_group);
> -	if (!rc)
> -		return 0;
> +	return 0;

Could've left a \n before the return so it doesn't look weird if only 
this patch is applied. But that's not important.

>   
> -	kset_unregister(uv_query_kset);
>   out_ind_files:
>   	sysfs_remove_files(uv_kobj, uv_prot_virt_attrs);
>   out_kobj:
> @@ -785,4 +798,4 @@ static int __init uv_info_init(void)
>   	kobject_put(uv_kobj);
>   	return rc;
>   }
> -device_initcall(uv_info_init);
> +device_initcall(uv_sysfs_init);