Re: [PATCH v6 4/7] xfs: Support FS_XFLAG_ATOMICWRITES

From: John Garry
Date: Tue Oct 01 2024 - 08:06:22 EST


On 01/10/2024 09:41, Christoph Hellwig wrote:
On Mon, Sep 30, 2024 at 09:03:49AM -0700, Darrick J. Wong wrote:
If we're only allowing atomic writes that are 1 fsblock or less, then
copy on write will work correctly because CoWs are always done with
fsblock granularity. The ioend remap is also committed atomically.

IOWs, it's forcealign that isn't compatible with reflink and you can
drop this incompatibility.
That was my thought as well when reading through this patch.

ok, fine. I just thought that we don't want to mix reflinked files and atomic writes at all. I do understand that there was also an incompatibility between forcealign and reflink.

Cheers,
John