Re: [PATCH v5 4/6] i2c: npcm: Modify the client address assignment

From: Andy Shevchenko
Date: Tue Oct 01 2024 - 09:17:49 EST


On Tue, Oct 01, 2024 at 02:28:53PM +0800, Tyrone Ting wrote:
> From: Tyrone Ting <kfting@xxxxxxxxxxx>
>
> Store the client address earlier since it might get called in
> the i2c_recover_bus() logic flow at the early stage of
> npcm_i2c_master_xfer().

...

> + /*
> + * Previously, the address was stored w/o left-shift by one bit and
> + * with that shift in the following call to npcm_i2c_master_start_xmit().
> + *
> + * Since there are cases that the i2c_recover_bus() gets called at the
> + * early stage of npcm_i2c_master_xfer(), the address is stored with
> + * the shift and used in the i2c_recover_bus().
> + *
> + * The address is stored from bit 1 to bit 7 in the register for
> + * sending the i2c address later so it's left-shifted by 1 bit.
> + */
> + bus->dest_addr = slave_addr << 1;

I'm wondering if it's better to use i2c_8bit_addr_from_msg() here?

--
With Best Regards,
Andy Shevchenko