RE: [PATCH 6/7] iio: adc: ad485x: add ad485x driver

From: Miclaus, Antoniu
Date: Tue Oct 01 2024 - 09:55:40 EST


> > Regarding the bulk writes/reads, the msb/mid/lsb registers need to be
> > read/write in a specific order and the addresses are not incremental,
>
> We have _noinc() variants of regmap accessors.
[Miclaus, Antoniu]
I think _noinc() functions read from the same register address so it doesn't
apply.
I am reading values from multiple register addresses that are not reg_addr,
reg_addr+1, reg_addr+2.

> > so I am not sure how the bulk functions fit. On this matter, we will need
> > unsigned int (not u8) to store the values read via regmap_read, and in this
> > case we will need extra casts and assignments to use get_unaligned.
>
> --
> With Best Regards,
> Andy Shevchenko
>