Re: [PATCH v3 05/20] gendwarfksyms: Expand base_type

From: Petr Pavlu
Date: Tue Oct 01 2024 - 10:08:21 EST


On 9/23/24 20:18, Sami Tolvanen wrote:
> Start making gendwarfksyms more useful by adding support for
> expanding DW_TAG_base_type types and basic DWARF attributes.
>
> Example:
>
> $ echo loops_per_jiffy | \
> scripts/gendwarfksyms/gendwarfksyms \
> --debug --dump-dies vmlinux.o
> ...
> gendwarfksyms: process_symbol: loops_per_jiffy
> variable base_type unsigned long byte_size(8) encoding(7)
> ...
>
> Signed-off-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx>
> [...]

Looks ok to me, feel free to add:
Reviewed-by: Petr Pavlu <petr.pavlu@xxxxxxxx>

--
Thanks,
Petr