Re: [PATCH v3 08/20] gendwarfksyms: Expand subroutine_type

[Petr Pavlu]

On 9/23/24 20:18, Sami Tolvanen wrote:
> Add support for expanding DW_TAG_subroutine_type and the parameters
> in DW_TAG_formal_parameter. Use this to also expand subprograms.
> 
> Example output with --dump-dies:
> 
>   subprogram (
>     formal_parameter pointer_type {
>       const_type {
>         base_type char byte_size(1) encoding(6)
>       }
>     }
>   )
>   -> base_type unsigned long byte_size(8) encoding(7)
> 
> Signed-off-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx>
> [...]

Looks ok to me, feel free to add:
Reviewed-by: Petr Pavlu <petr.pavlu@xxxxxxxx>

-- 
Thanks,
Petr