Re: [PATCH v3 09/20] gendwarfksyms: Expand array_type
From: Petr Pavlu
Date: Tue Oct 01 2024 - 10:17:56 EST
On 9/23/24 20:18, Sami Tolvanen wrote:
> Add support for expanding DW_TAG_array_type, and the subrange type
> indicating array size.
>
> Example source code:
>
> const char *s[34];
>
> Output with --dump-dies:
>
> variable array_type[34] {
> pointer_type {
> const_type {
> base_type char byte_size(1) encoding(6)
> }
> } byte_size(8)
> }
>
> Signed-off-by: Sami Tolvanen <samitolvanen@xxxxxxxxxx>
> [...]
Looks ok to me, feel free to add:
Reviewed-by: Petr Pavlu <petr.pavlu@xxxxxxxx>
--
Thanks,
Petr