Re: [PATCH v2 4/4] ARM: dts: microchip: aks-cdu: Add label for LED sub nodes

[Conor Dooley]

On Tue, Oct 01, 2024 at 06:25:41PM +0300, Andrei Simion wrote:
> Add the label property here and use the old node name as value to stay
> stable and avoid breaking the userspace applications that depend on those
> paths.
> 
> Suggested-by: Alexander Dhal <ada@xxxxxxxxxxx>
> Signed-off-by: Andrei Simion <andrei.simion@xxxxxxxxxxxxx>

Shouldn't this be squashed with 3/4 so as not to break it in one commit,
only to fix it in another?

> ---
> v1 -> v2:
> - added in v2 by suggestion of Alexander Dhal
> ---
>  arch/arm/boot/dts/microchip/aks-cdu.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/microchip/aks-cdu.dts b/arch/arm/boot/dts/microchip/aks-cdu.dts
> index 0c3373ad1723..b65f80e1ef05 100644
> --- a/arch/arm/boot/dts/microchip/aks-cdu.dts
> +++ b/arch/arm/boot/dts/microchip/aks-cdu.dts
> @@ -99,22 +99,26 @@ leds {
>  		compatible = "gpio-leds";
>  
>  		led-red {
> +			label = "red";
>  			gpios = <&pioC 10 GPIO_ACTIVE_HIGH>;
>  			linux,default-trigger = "none";
>  		};
>  
>  		led-green {
> +			label = "green";
>  			gpios = <&pioA 5 GPIO_ACTIVE_LOW>;
>  			linux,default-trigger = "none";
>  			default-state = "on";
>  		};
>  
>  		led-yellow {
> +			label = "yellow";
>  			gpios = <&pioB 20 GPIO_ACTIVE_LOW>;
>  			linux,default-trigger = "none";
>  		};
>  
>  		led-blue {
> +			label = "blue";
>  			gpios = <&pioB 21 GPIO_ACTIVE_LOW>;
>  			linux,default-trigger = "none";
>  		};
> -- 
> 2.34.1
>

Attachment: signature.asc
Description: PGP signature