Re: [PATCH] btrfs: remove redundant stop_loop variable in scrub_stripe()

[David Sterba]

On Thu, Sep 26, 2024 at 01:20:34PM +0530, Riyan Dhiman wrote:
> The variable stop_loop was originally introduced in commit
> 625f1c8dc66d7 (Btrfs: improve the loop of scrub_stripe). It was initialized
> to 0 in commit 3b080b2564287 (Btrfs: scrub raid56 stripes in the right way).
> However, in a later commit 18d30ab961497 (btrfs: scrub: use scrub_simple_mirror()
> to handle RAID56 data stripe scrub), the code that modified stop_loop was removed,
> making the variable redundant.
> 
> Currently, stop_loop is only initialized with 0 and is never used or modified
> within the scrub_stripe() function. As a result, this patch removes the
> stop_loop variable to clean up the code and eliminate unnecessary redundancy.
> 
> This change has no impact on functionality, as stop_loop was never utilized
> in any meaningful way in the final version of the code.
> 
> Signed-off-by: Riyan Dhiman <riyandhiman14@xxxxxxxxx>

Added to for-next, thanks. Adding the references when the code was added
or last used is great, I slightly updated the references as it's common
to use the same formatting like the Fixes: tag which puts the subject to
("...").