Re: [PATCH v1 3/6] s390/uvdevice: Add Retrieve Secret IOCTL

From: Christoph Schlameuss
Date: Tue Oct 01 2024 - 12:19:05 EST


On Mon Sep 30, 2024 at 3:19 PM CEST, Steffen Eiden wrote:
> Add a new IOCL number to support the new Retrieve Secret UVC for
> user-space.
> User-space provides the index of the secret (u16) to retrieve.
> The uvdevice calls the Retrieve Secret UVC and copies the secret into
> the provided buffer if it fits. To get the secret type, index, and size
> user-space needs to call the List UVC first.
>
> Reviewed-by: Janosch Frank <frankja@xxxxxxxxxxxxx>
> Signed-off-by: Steffen Eiden <seiden@xxxxxxxxxxxxx>

Reviewed-by: Christoph Schlameuss <schlameuss@xxxxxxxxxxxxx>

> ---
> arch/s390/include/uapi/asm/uvdevice.h | 4 ++
> drivers/s390/char/uvdevice.c | 56 +++++++++++++++++++++++++++
> 2 files changed, 60 insertions(+)

[...]