Re: [PATCH 2/4] dt-bindings: iio: adc: Add the GE HealthCare PMC ADC

[Conor Dooley]

On Tue, Oct 01, 2024 at 06:46:02PM +0200, Herve Codina wrote:
> On Tue, 1 Oct 2024 17:18:30 +0100
> Conor Dooley <conor@xxxxxxxxxx> wrote:
> 
> > On Tue, Oct 01, 2024 at 09:46:16AM +0200, Herve Codina wrote:
> > > The GE HealthCare PMC Analog to Digital Converter (ADC) is a 16-Channel
> > > (voltage and current), 16-Bit ADC with an I2C Interface.
> > > 
> > > Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx>
> > > ---
> > >  .../bindings/iio/adc/gehc,pmc-adc.yaml        | 82 +++++++++++++++++++
> > >  include/dt-bindings/iio/adc/gehc,pmc-adc.h    | 10 +++
> ...
> > > +  clocks:
> > > +    maxItems: 1
> > > +
> > > +  clock-names:
> > > +    items:
> > > +      - const: osc  
> > 
> > Since there's no datasheet for me to look up, why is the clock optional?
> 
> The component uses an external oscillator (osc) if an external oscillator is
> connected to its clock pins. Otherwise, it uses an internal reference clock.

Could you please add a description of the clock with this statement,
given there's no datasheet or w/e linked here?

Attachment: signature.asc
Description: PGP signature