Re: [PATCH net-next 07/15] net: sparx5: use SPX5_CONST for constants which already have a symbol
From: Jacob Keller
Date: Tue Oct 01 2024 - 13:58:51 EST
On 10/1/2024 6:50 AM, Daniel Machon wrote:
> Now that we have indentified all the chip constants, update the use of
> them where a symbol is already defined for the constant.
>
> Constants are accessed using the SPX5_CONSTS macro. Note that this macro
> might hide the use of the *sparx5 context pointer. In such case, a
> comment is added.
>
I guess its shorter than doing something like 'SPX5_CONST(sparx5,
<constant>)'? Is that really worth it over the additional burden of
tracking that this macro accesses the struct?
> Signed-off-by: Daniel Machon <daniel.machon@xxxxxxxxxxxxx>
> Reviewed-by: Steen Hegelund <Steen.Hegelund@xxxxxxxxxxxxx>