On Tue, Oct 01, 2024 at 12:09:03PM -0700, Yang Shi wrote:
On 10/1/24 11:27 AM, Nicolin Chen wrote:ARM64 can have aarch32 support. I am not sure if ARM64 running a
On Tue, Oct 01, 2024 at 11:03:46AM -0700, Yang Shi wrote:It shouldn't. Because smmu v3 depends on ARM64.
Using 64 bit immediate when doing shift can solve the problem. The[...]
disssembly after the fix looks like:
unsigned int last_sid_idx =Could a 32-bit build be a corner case where UL is no longer a
- arm_smmu_strtab_l1_idx((1 << smmu->sid_bits) - 1);
+ arm_smmu_strtab_l1_idx((1UL << smmu->sid_bits) - 1);
"64 bit" stated in the commit message?
config ARM_SMMU_V3
tristate "ARM Ltd. System MMU Version 3 (SMMUv3) Support"
depends on ARM64
32-bit OS can be a case though, (and not confined to AmpereOne).
Rechecked the RM. Yea, max sid can be 32 but max ssid is 20 atThen, can ssid_bits/s1cdmax be a concern similarly?IIUC, ssid_bits is determined by IDR1_SSIDSIZE. It is GENMASK(10, 6). So
it shouldn't be 32. IDR1_SIDSIZE is GENMASK(5, 0).
this moment, so we should be safe.
Thanks
Nicolin