Re: [PATCH] iommu/arm-smmu-v3: Fix L1 stream table index calculation for AmpereOne

From: Yang Shi
Date: Tue Oct 01 2024 - 17:33:06 EST




On 10/1/24 2:02 PM, Jason Gunthorpe wrote:
On Tue, Oct 01, 2024 at 01:47:24PM -0700, Yang Shi wrote:
diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h
b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h
index 1e9952ca989f..de9f14293485 100644
--- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h
+++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h
@@ -235,6 +235,11 @@ static inline u32 arm_smmu_strtab_l2_idx(u32 sid)
return sid % STRTAB_NUM_L2_STES;
}

+static inline unsigned int arm_smmu_strtab_max_sid(unsigned int sid_bits)
+{
Can we take the smmu struct here instead of the int?

No problem.


But yes, this looks OK

Thank you.


Jason