Re: [PATCHv2 net-next 01/10] net: lantiq_etop: use netif_receive_skb_list

[Andrew Lunn]

On Tue, Oct 01, 2024 at 11:45:58AM -0700, Rosen Penev wrote:
> Improves cache efficiency by batching rx skb processing. Small
> performance improvement on RX.

Benchmark numbers would be good.

> 
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> Reviewed-by: Shannon Nelson <shannon.nelson@xxxxxxx>
> ---
>  drivers/net/ethernet/lantiq_etop.c | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
> index 3c289bfe0a09..94b37c12f3f7 100644
> --- a/drivers/net/ethernet/lantiq_etop.c
> +++ b/drivers/net/ethernet/lantiq_etop.c
> @@ -122,8 +122,7 @@ ltq_etop_alloc_skb(struct ltq_etop_chan *ch)
>  	return 0;
>  }
>  
> -static void
> -ltq_etop_hw_receive(struct ltq_etop_chan *ch)
> +static void ltq_etop_hw_receive(struct ltq_etop_chan *ch, struct list_head *lh)

Please don't put the return type on the same line. If you look at this
driver, it is the coding style to always have it on a separate
line. You broken the coding style.


    Andrew

---
pw-bot: cr