Re: [PATCH v4 5/5] dt-bindings: display: mediatek: dpi: correct power-domains property

From: Macpaul Lin
Date: Tue Oct 01 2024 - 23:09:30 EST




On 10/2/24 09:51, Rob Herring wrote:


External email : Please do not click links or open attachments until you have verified the sender or the content.

On Mon, Sep 30, 2024 at 04:38:54PM +0800, Macpaul Lin wrote:
The MediaTek DPI module is typically associated with one of the
following multimedia power domains:
- POWER_DOMAIN_DISPLAY
- POWER_DOMAIN_VDOSYS
- POWER_DOMAIN_MM
The specific power domain used varies depending on the SoC design.

These power domains are shared by multiple devices within the SoC.
In most cases, these power domains are enabled by other devices.
As a result, the DPI module of legacy SoCs often functions correctly
even without explicit configuration.

It is recommended to explicitly add the appropriate power domain
property to the DPI node in the device tree. Hence drop the
compatible checking for specific SoCs.

Fixes: 5474d49b2f79 ("dt-bindings: display: mediatek: dpi: Add power domains")
Signed-off-by: Macpaul Lin <macpaul.lin@xxxxxxxxxxxx>
Signed-off-by: Jitao Shi <jitao.shi@xxxxxxxxxxxx>
Signed-off-by: Pablo Sun <pablo.sun@xxxxxxxxxxxx>
---
.../display/mediatek/mediatek,dpi.yaml | 24 ++++++++-----------
1 file changed, 10 insertions(+), 14 deletions(-)

You missed Krzysztof's R-by tag.


Oh, I just missed that reply for v3 in the mailbox
and thought it still need to be reviewed.
I just found Krzysztof's R-by tag in the mailbox right now.

I'll send an update for this patch set.
Thanks for the reminder.

Regards,
Macpaul Lin